Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AESinkALSA: change name to ALSA #13170

Merged
merged 1 commit into from Dec 11, 2017
Merged

AESinkALSA: change name to ALSA #13170

merged 1 commit into from Dec 11, 2017

Conversation

fritsch
Copy link
Member

@fritsch fritsch commented Dec 11, 2017

C/P I assume.

@FernetMenta
Copy link
Contributor

FernetMenta commented Dec 11, 2017 •
edited

oops 😁

@FernetMenta FernetMenta merged commit 014d7f6 into xbmc:master Dec 11, 2017
@fritsch
Copy link
Member Author

fritsch commented Dec 11, 2017

Btw. this has overwritten the hashmap entry, but currently I don't get into the Optionals Init Method at all and for me always ALSA is enumerated even if the sink's name is PULSE - seems there is a problem finding the right Create function ptr.

@Rechi Rechi added Component: Audio Type: Fix non-breaking change which fixes an issue Platform: Linux v18 Leia labels Dec 13, 2017
@Rechi Rechi added this to the L 18.0-alpha1 milestone Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FernetMenta FernetMenta Awaiting requested review from FernetMenta

Assignees
No one assigned
Labels
Component: Audio Platform: Linux Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Milestone
Leia 18.0-alpha1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fritsch @FernetMenta @Rechi